linux-kernel - Re: [PATCH] crypto: AEAD: add check for presence of auth tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1533111.7lv9uhtZ5L@tachyon.chronox.de>
Date:	Mon, 05 Jan 2015 12:00:36 +0100
From:	Stephan Mueller <smueller@...onox.de>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	'LKML' <linux-kernel@...r.kernel.org>, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] crypto: AEAD: add check for presence of auth tag

Am Montag, 5. Januar 2015, 21:55:40 schrieb Herbert Xu:

Hi Herbert,

> On Mon, Jan 05, 2015 at 11:53:38AM +0100, Stephan Mueller wrote:
> > Could you please check: I am unable to find the function.
> 
> It's in crypto/authenc.c.
> 
> > Note, there is no size parameter provided in crypto_aead_decrypt. To
> > obtain
> > the size, I would need to walk the scatterlists, no?
> 
> The cryptlen is supposed to contain the entire input apart from the
> AD, including the authentication tag if one is present.

Thanks a lot for the pointer, I overlooked the cryptlen member variable. I 
will update the patch to replace the scatterlist walk with such small check.

-- 
Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/