lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 05 Jan 2015 02:30:03 +0000
From:	Ben Hutchings <>
To:	Maciej ┼╗enczykowski <>
Cc:	David Decotigny <>,
	Amir Vadai <>,
	Florian Fainelli <>,
	Linux NetDev <>,
	Linux Kernel Mailing List <>,, David Decotigny <>,
	"David S. Miller" <>,
	Jason Wang <>,
	"Michael S. Tsirkin" <>,
	Herbert Xu <>,
	Al Viro <>,
	Masatake YAMATO <>, Xi Wang <>,
	Neil Horman <>,
	WANG Cong <>,
	Flavio Leitner <>, Tom Gundersen <>,
	Jiri Pirko <>,
	Vlad Yasevich <>,
	"Eric W. Biederman" <>,
	Saeed Mahameed <>,
	Venkata Duvvuru <>,
	Govindarajulu Varadarajan <>
Subject: Re: [PATCH net-next v1 0/7] net: extend ethtool link mode bitmaps
 to 48 bits

On Mon, 2015-01-05 at 01:34 +0100, Maciej ┼╗enczykowski wrote:
> >> I can send updates to other drivers, even though it's rather pointless
> >> to update 1G drivers at this point for example. Please let me know,
> >> but I'd prefer to do this in follow-up patches outside this first
> >> patch series.
> > [...]
> >
> > They should be changed to ensure they reject setting any of the high
> > advertising flags, but it's not urgent.
> if old drivers advertised a get/set_bits function while new drivers
> advertised a get/set_new_bits function,
> you could not updated any old drivers, and simply take care of
> rejecting invalid bits in core, by calling set_new_bits if provided,
> if not, rejecting bad bits and calling set_bits if no bad bits were
> set.

We've never checked that the reserved fields are zero before, and I
think there are still drivers that don't fully validate the existing 32
bits.  So while I think drivers should fully validate the advertising
flags, userland generally can't assume they do.  And therefore I don't
think it's worth adding complexity to the ethtool core that only partly
fixes this.


Ben Hutchings
This sentence contradicts itself - no actually it doesn't.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)

Powered by blists - more mailing lists