linux-kernel - Re: [PATCH 2/2] ARM: mediatek: dts: Add uart to Aquaris5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150105122849.GF4544@pengutronix.de>
Date:	Mon, 5 Jan 2015 13:28:49 +0100
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Matthias Brugger <matthias.bgg@...il.com>
Cc:	linux-kernel@...r.kernel.org, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linux@....linux.org.uk, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] ARM: mediatek: dts: Add uart to Aquaris5

Hi Matthias,

On Fri, Jan 02, 2015 at 07:48:05PM +0100, Matthias Brugger wrote:
> This patch enables uart port for the Aquaris5 mobile phone.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@...il.com>
> ---
>  arch/arm/boot/dts/mt6589-aquaris5.dts | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/mt6589-aquaris5.dts b/arch/arm/boot/dts/mt6589-aquaris5.dts
> index 0da0470..d5cbfda 100644
> --- a/arch/arm/boot/dts/mt6589-aquaris5.dts
> +++ b/arch/arm/boot/dts/mt6589-aquaris5.dts
> @@ -21,10 +21,16 @@
>  	compatible = "mundoreader,bq-aquaris5", "mediatek,mt6589";
>  
>  	chosen {
> -		bootargs = "earlyprintk";
> +		bootargs = "console=ttyS0,921600n8 earlyprintk";
>  	};

		stdout-path = &uart0;

Should work aswell and makes you independent from the way the kernel
decides to number the UARTs.

>  
>  	memory {
>  		reg = <0x80000000 0x40000000>;
>  	};
> +
> +	soc {
> +		uart0: serial@...06000 {
> +			status = "okay";
> +		};
> +	};

By using the & notation you don't have to resemble the tree structure in
the board file, like this:

&uart0 {
	status = "okay";
};

See for example the omap, i.MX or other dts files.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/