linux-kernel - Re: [PATCH 1/1 linux-next] hp100: simplify hp100_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150104.222313.844590125087915248.davem@davemloft.net>
Date:	Sun, 04 Jan 2015 22:23:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	fabf@...net.be
Cc:	linux-kernel@...r.kernel.org, perex@...ex.cz,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1 linux-next] hp100: simplify hp100_module_init

From: Fabian Frederick <fabf@...net.be>
Date: Sat,  3 Jan 2015 14:44:16 +0100

> -Avoid double goto and directly return err where possible.
> -Remove unused labels which fixes:
> 
> drivers/net/ethernet/hp/hp100.c:3047:2: warning: label
> 'out3' defined but not used [-Wunused-label]
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
> This is untested.

Having a sole lone return statement that all flows of control
branch to makes the code easier to audit, than to have a huge
block where each return statement has to be audited independently
for potential cleanups.

Added to the fact that this patch is completely untested, I'm
not applying this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/