linux-kernel - Re: [PATCH] fbdev: geocode: remove unneeded NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54AA8A3F.8080800@ti.com>
Date:	Mon, 5 Jan 2015 14:57:35 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
CC:	<linux-geode@...ts.infradead.org>, <linux-fbdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fbdev: geocode: remove unneeded NULL check

On 31/12/14 08:55, Sudip Mukherjee wrote:
> the check for info is not required as we are checking it immediately
> after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL.
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
>  drivers/video/fbdev/geode/gx1fb_core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/fbdev/geode/gx1fb_core.c b/drivers/video/fbdev/geode/gx1fb_core.c
> index 2794ba1..9bee874 100644
> --- a/drivers/video/fbdev/geode/gx1fb_core.c
> +++ b/drivers/video/fbdev/geode/gx1fb_core.c
> @@ -374,10 +374,8 @@ static int gx1fb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  		release_mem_region(gx1_gx_base() + 0x8300, 0x100);
>  	}
>  
> -	if (info) {
> -		fb_dealloc_cmap(&info->cmap);
> -		framebuffer_release(info);
> -	}
> +	fb_dealloc_cmap(&info->cmap);
> +	framebuffer_release(info);
>  
>  	return ret;
>  }
> 

Thanks, queued for 3.20.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)