| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150105132301.GA15833@htj.dyndns.org> Date: Mon, 5 Jan 2015 08:23:01 -0500 From: Tejun Heo <tj@...nel.org> To: Jan Kara <jack@...e.cz> Cc: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>, "David S. Miller" <davem@...emloft.net>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] lib: flex_proportions.c: Remove some unused functions On Mon, Jan 05, 2015 at 09:45:34AM +0100, Jan Kara wrote: > On Sat 20-12-14 15:40:31, Rickard Strandqvist wrote: > > Removes some functions that are not used anywhere: > > prop_fraction_single() prop_local_destroy_single() prop_local_init_single() fprop_global_destroy() > > > > This was partially found by using a static code analysis program called cppcheck. > This is the same situation as with lib/proportions.c. The functions are > there for API completeness. As far as I'm looking the whole 'single' > section is unused so ifdeffing it out might make sense (and also ifdeffing > out fprop_inc_single() from include/linux/flex_proportions.h). Removing > fprop_global_destroy() is IMO pointless churn. I'll prolly use some of the now unused portion of the API to implement per-memcg dirty ratio for cgroup writeback, so let's please leave it alone for now. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists