lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Jan 2015 15:05:46 +0100 From: Linus Walleij <linus.walleij@...aro.org> To: Krzysztof Kozlowski <k.kozlowski@...sung.com>, Tomasz Figa <tomasz.figa@...il.com> Cc: Mike Turquette <mturquette@...aro.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>, Kukjin Kim <kgene@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-samsung-soc <linux-samsung-soc@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Javier Martinez Canillas <javier.martinez@...labora.co.uk>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Vivek Gautam <gautam.vivek@...sung.com>, Kevin Hilman <khilman@...nel.org>, Kyungmin Park <kyungmin.park@...sung.com>, Marek Szyprowski <m.szyprowski@...sung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> Subject: Re: [PATCH v4 2/3] pinctrl: exynos: Fix GPIO setup failure because domain clock being gated On Fri, Dec 5, 2014 at 12:00 PM, Krzysztof Kozlowski <k.kozlowski@...sung.com> wrote: > The audio subsystem on Exynos 5420 has separate clocks and GPIO. To > operate properly on GPIOs the main block clock 'mau_epll' must be > enabled. > > This was observed on Peach Pi/Pit and Arndale Octa (after enabling i2s0) > after introducing runtime PM to pl330 DMA driver. After that commit the > 'mau_epll' was gated, because the "amba" clock was disabled and there > were no more users of mau_epll. > > The system hang just before probing i2s0 because > samsung_pinmux_setup() tried to access memory from audss block which was > gated. > > Add a clock property to the pinctrl driver and enable the clock during > GPIO setup. During normal GPIO operations (set, get, set_direction) the > clock is not enabled. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> > Tested-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk> Tomasz, is this OK and should I apply it for fixes or next? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists