linux-kernel - Re: [PATCH v2] kernfs: Fix kernfs_name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150105141347.GH15833@htj.dyndns.org>
Date:	Mon, 5 Jan 2015 09:13:47 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kernfs: Fix kernfs_name_compare

On Fri, Dec 05, 2014 at 11:41:33PM +0100, Rasmus Villemoes wrote:
> Returning a difference from a comparison functions is usually wrong
> (see acbbe6fbb240 "kcmp: fix standard comparison bug" for the long
> story). Here there is the additional twist that if the void pointers
> ns and kn->ns happen to differ by a multiple of 2^32,
> kernfs_name_compare returns 0, falsely reporting a match to the
> caller.
> 
> Technically 'hash - kn->hash' is ok since the hashes are restricted to
> 31 bits, but it's better to avoid that subtlety.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Acked-by: Tejun Heo <tj@...nel.org>

And this is a -stable material.  Greg, can you please pick this one
up?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/