lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 5 Jan 2015 13:33:05 -0400
From:	Marc Dionne <marc.c.dionne@...il.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [GIT PULL] fuse update for 3.19

On Mon, Jan 5, 2015 at 1:11 PM, Miklos Szeredi <miklos@...redi.hu> wrote:
> On Wed, Dec 24, 2014 at 12:53:13PM -0400, Marc Dionne wrote:
>
>> Commit 7078187a795f ("fuse: introduce fuse_simple_request() helper")
>> from the above pull request triggers some EIO errors for me in some
>> tests that rely on fuse.
>>
>> Looking at the code changes and a bit of debugging info I think
>> there's a general problem here that fuse_get_req checks and possibly
>> waits for fc->initialized, and this was always called first.  But this
>> commit changes the ordering and in many places fc->minor is now
>> possibly used before fuse_get_req, and we can't be sure that fc has
>> been initialized.  In my case fuse_lookup_init sets
>> req->out.args[0].size to the wrong size because fc->minor at that
>> point is still 0, leading to the EIO error.
>>
>> Assuming the analysis makes sense, it wasn't obvious what the best fix
>> should be.
>
> Here's a patch to fix this.  Could you please give it a try?
>
> Thanks,
> Miklos

Works fine with my test case that fails on current master.

Thanks,
Marc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists