linux-kernel - RE: [PATCH 00/45] staging: comedi: fix up some driver comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DC148C5AA1CEBA4E87973D432B1C2D88260B7633@P3PWEX4MB008.ex4.secureserver.net>
Date:	Mon, 5 Jan 2015 18:55:14 +0000
From:	Hartley Sweeten <HartleyS@...ionengravers.com>
To:	Ian Abbott <abbotti@....co.uk>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 00/45] staging: comedi: fix up some driver comments

On Monday, January 05, 2015 10:54 AM, Ian Abbott wrote:
> Most comedi drivers have a special comedi driver comment block,
> information from which can be extracted by some scripts for use in the
> "Comedilib" manual and the list of supported devices on the comedi web
> site.  (Currently, the information for those places comes from the
> "out-of-tree" comedi drivers.)
>
> The "Devices:" line (and continuation lines) are supposed to be a
> comma-(and space)-separated list with the first item in this format:
>
>   [Manufacturer] BOARD-NAME (comedi-board-name)
>
> The "[Manufacturer]" and "(comedi-board-name)" parts can be omitted from
> subsequent list items to decrease verbosity, in which case they are
> assumed to be the same as the preceding item.
>
> Several comedi drivers have the "Devices:" line formatted incorrectly,
> often with the use of square brackets and parentheses reversed.  A few
> comedi modules have driver comments, but are just support modules for
> other drivers, so don't really need a driver comment.

Ian,

There are a number of drivers that still need the comedi comment block
converted to the normal CodingStyle format for multi-line comments.

And, as you mentioned to me before, all of the ADDI-DATA drivers
are missing the comedi comment block:

But, this is a great start to getting them cleaned up.

Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/