lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 5 Jan 2015 13:39:49 -0600
From:	Dimitri Sivanich <sivanich@....com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: sgi-gru: gruhandles.c:  Remove unused function

Acked-by: Dimitri Sivanich <sivanich@....com>

On Thu, Jan 01, 2015 at 05:46:47PM +0100, Rickard Strandqvist wrote:
> Remove the function tfh_restart() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  drivers/misc/sgi-gru/gruhandles.c |    6 ------
>  drivers/misc/sgi-gru/gruhandles.h |    1 -
>  2 files changed, 7 deletions(-)
> 
> diff --git a/drivers/misc/sgi-gru/gruhandles.c b/drivers/misc/sgi-gru/gruhandles.c
> index 2f30bad..1ee8e82 100644
> --- a/drivers/misc/sgi-gru/gruhandles.c
> +++ b/drivers/misc/sgi-gru/gruhandles.c
> @@ -196,12 +196,6 @@ void tfh_write_restart(struct gru_tlb_fault_handle *tfh,
>  	start_instruction(tfh);
>  }
>  
> -void tfh_restart(struct gru_tlb_fault_handle *tfh)
> -{
> -	tfh->opc = TFHOP_RESTART;
> -	start_instruction(tfh);
> -}
> -
>  void tfh_user_polling_mode(struct gru_tlb_fault_handle *tfh)
>  {
>  	tfh->opc = TFHOP_USER_POLLING_MODE;
> diff --git a/drivers/misc/sgi-gru/gruhandles.h b/drivers/misc/sgi-gru/gruhandles.h
> index 3f998b9..3d7bd36 100644
> --- a/drivers/misc/sgi-gru/gruhandles.h
> +++ b/drivers/misc/sgi-gru/gruhandles.h
> @@ -524,7 +524,6 @@ int tfh_write_only(struct gru_tlb_fault_handle *tfh, unsigned long paddr,
>  	int gaa, unsigned long vaddr, int asid, int dirty, int pagesize);
>  void tfh_write_restart(struct gru_tlb_fault_handle *tfh, unsigned long paddr,
>  	int gaa, unsigned long vaddr, int asid, int dirty, int pagesize);
> -void tfh_restart(struct gru_tlb_fault_handle *tfh);
>  void tfh_user_polling_mode(struct gru_tlb_fault_handle *tfh);
>  void tfh_exception(struct gru_tlb_fault_handle *tfh);
>  
> -- 
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists