linux-kernel - Re: [PATCH] checkpatch: add check for keyword 'boolean' in Kconfig definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1420499776.14308.50.camel@x220>
Date:	Tue, 06 Jan 2015 00:16:16 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Christoph Jaeger <cj@...ux.com>
Cc:	apw@...onical.com, joe@...ches.com, linux-kernel@...r.kernel.org,
	dborkman@...hat.com
Subject: Re: [PATCH] checkpatch: add check for keyword 'boolean' in Kconfig
 definitions

On Sat, 2014-12-20 at 15:40 -0500, Christoph Jaeger wrote:
> Discourage the use of keyword 'boolean' for type definition attributes of
> config options as support for it will be dropped later on.
> 
> Reference: http://lkml.kernel.org/r/cover.1418003065.git.cj@linux.com
> Suggested-by: Daniel Borkmann <dborkman@...hat.com>
> Signed-off-by: Christoph Jaeger <cj@...ux.com>

Works as advertised:
    $ scripts/checkpatch.pl -f kernel/livepatch/Kconfig 
    WARNING: Use of boolean is deprecated, please use bool instead.
    #2: FILE: kernel/livepatch/Kconfig:2:
    +        boolean

    WARNING: Use of boolean is deprecated, please use bool instead.
    #7: FILE: kernel/livepatch/Kconfig:7:
    +        boolean "Kernel Live Patching"

    total: 0 errors, 2 warnings, 18 lines checked

    kernel/livepatch/Kconfig has style problems, please review.

    If any of these errors are false positives, please report
    them to the maintainer, see CHECKPATCH in MAINTAINERS.

Acked-by: Paul Bolle <pebolle@...cali.nl>

> ---
>  scripts/checkpatch.pl | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index f0bb6d6..cae974e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2355,6 +2355,13 @@ sub process {
>  			     "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
>  		}
>  
> +# discourage the use of boolean for type definition attributes of Kconfig options
> +		if ($realfile =~ /Kconfig/ &&
> +		    $line =~ /^\+\s*\bboolean\b/) {
> +			WARN("CONFIG_TYPE_BOOLEAN",

This should become an error once "boolean" is removed (on some future
date).

> +			     "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
> +		}
> +
>  		if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
>  		    ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
>  			my $flag = $1;


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/