linux-kernel - Re: [PATCH] ceph: acl: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 6 Jan 2015 15:05:17 +0800
From:	"Yan, Zheng" <ukernel@...il.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Sage Weil <sage@...tank.com>,
	ceph-devel <ceph-devel@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ceph: acl: Remove unused function

On Sun, Jan 4, 2015 at 7:44 AM, Rickard Strandqvist
<rickard_strandqvist@...ctrumdigital.se> wrote:
> Remove the function ceph_get_cached_acl() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  fs/ceph/acl.c |   14 --------------
>  1 file changed, 14 deletions(-)
>
> diff --git a/fs/ceph/acl.c b/fs/ceph/acl.c
> index 5bd853b..64fa248 100644
> --- a/fs/ceph/acl.c
> +++ b/fs/ceph/acl.c
> @@ -40,20 +40,6 @@ static inline void ceph_set_cached_acl(struct inode *inode,
>         spin_unlock(&ci->i_ceph_lock);
>  }
>
> -static inline struct posix_acl *ceph_get_cached_acl(struct inode *inode,
> -                                                       int type)
> -{
> -       struct ceph_inode_info *ci = ceph_inode(inode);
> -       struct posix_acl *acl = ACL_NOT_CACHED;
> -
> -       spin_lock(&ci->i_ceph_lock);
> -       if (__ceph_caps_issued_mask(ci, CEPH_CAP_XATTR_SHARED, 0))
> -               acl = get_cached_acl(inode, type);
> -       spin_unlock(&ci->i_ceph_lock);
> -
> -       return acl;
> -}
> -
>  struct posix_acl *ceph_get_acl(struct inode *inode, int type)
>  {
>         int size;
> --
> 1.7.10.4
>

added to testing branch.

Thanks


> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/