linux-kernel - Re: [PATCH] GMAC: fix simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1420529180.2652.31.camel@perches.com>
Date:	Mon, 05 Jan 2015 23:26:20 -0800
From:	Joe Perches <joe@...ches.com>
To:	Roger <roger.chen@...k-chips.com>
Cc:	David Miller <davem@...emloft.net>, fengguang.wu@...el.com,
	kbuild-all@...org, peppe.cavallaro@...com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] GMAC: fix simple_return.cocci warnings

On Tue, 2015-01-06 at 15:13 +0800, Roger wrote:
> What should I do now?

I think it would be better to change
"int gmac_clk_enable" to "void gmac_clk_enable"
(it always returns 0)

This function should simply call gmac_clk_enable
and return 0;

> >>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> >>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> >>> @@ -422,11 +422,7 @@ static int rk_gmac_init(struct platform_
> >>>   	if (ret)
> >>>   		return ret;
> >>>   
> >>> -	ret = gmac_clk_enable(bsp_priv, true);
> >>> -	if (ret)
> >>> -		return ret;
> >>> -
> >>> -	return 0;
> >>> +	return gmac_clk_enable(bsp_priv, true);
> >> I think this change is not particularly better.
> >>
> >> When the pattern is multiply repeated like:
> >   ...
> >> I think it's better to not change the last
> >> test in the sequence just to minimize overall
> >> line count.
> > I think it's a wash and that both ways are about the same to me.
> >
> > I won't apply this, sorry.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/