linux-kernel - Re: [PATCH] Added virtual com port VID/PID entries for CEL USB sticks and MeshWorks devices Signed-off-by: David Peterson <david.peterson@....com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150106080128.GA27633@localhost>
Date:	Tue, 6 Jan 2015 09:01:28 +0100
From:	Johan Hovold <johan@...nel.org>
To:	"Peterson, David" <David.Peterson@....com>
Cc:	"johan@...nel.org" <johan@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Added virtual com port VID/PID entries for CEL USB
 sticks and MeshWorks devices Signed-off-by: David Peterson
 <david.peterson@....com>

[ +CC: linux-usb]

On Mon, Jan 05, 2015 at 08:46:52PM +0000, Peterson, David wrote:
> From: David Peterson <david.peterson@....com>

Almost there. Patch looks fine now, but the mail Subject (commit
summary) is malformed (includes a sign-off tag).

Care to resend with a subject like

	"USB: cp210x: add ids for CEL USB sticks and MeshWorks devices"

It doesn't hurt including a commit message (e.g. your current Subject)
between From: and Signed-off-by: in the body.

> Signed-off-by: David Peterson <david.peterson@....com>
> ---
>  drivers/usb/serial/cp210x.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index 6c4eb3c..a6db2fc 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -120,6 +120,9 @@ static const struct usb_device_id id_table[] = {
>  	{ USB_DEVICE(0x10C4, 0x85F8) }, /* Virtenio Preon32 */
>  	{ USB_DEVICE(0x10C4, 0x8664) }, /* AC-Services CAN-IF */
>  	{ USB_DEVICE(0x10C4, 0x8665) }, /* AC-Services OBD-IF */
> +	{ USB_DEVICE(0x10C4, 0x8856) }, /* CEL EM357 ZigBee USB Stick - LR */
> +	{ USB_DEVICE(0x10C4, 0x8857) }, /* CEL EM357 ZigBee USB Stick */
> +	{ USB_DEVICE(0x10C4, 0x8977) }, /* CEL MeshWorks DevKit Device */
>  	{ USB_DEVICE(0x10C4, 0x8875) }, /* CEL MeshConnect USB Stick */

By the way, a recent patch changed this one to 0x8857. Is this indeed
the same device as CEL EM357?

	http://marc.info/?l=linux-usb&m=141966558701806&w=2

>  	{ USB_DEVICE(0x10C4, 0x88A4) }, /* MMB Networks ZigBee USB Device */
>  	{ USB_DEVICE(0x10C4, 0x88A5) }, /* Planet Innovation Ingeni ZigBee USB Device */

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/