linux-kernel - Re: [PATCH v2] mailbox: Add Altera mailbox driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFiDJ58yQcyYDiL9PaD-fP23dpjcLEibw9cDYKW7g2Sb9oYgQw@mail.gmail.com>
Date:	Tue, 6 Jan 2015 16:33:23 +0800
From:	Ley Foon Tan <lftan.linux@...il.com>
To:	Jassi Brar <jassisinghbrar@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	Ley Foon Tan <lftan@...era.com>,
	Ley Foon Tan <lftan.linux@...il.com>,
	Suman Anna <s-anna@...com>, devicetree@...r.kernel.org,
	Dinh Nguyen <dinh.linux@...il.com>
Subject: Re: [PATCH v2] mailbox: Add Altera mailbox driver

On Mon, Dec 22, 2014 at 5:44 PM, Ley Foon Tan <lftan@...era.com> wrote:
> The Altera mailbox allows for interprocessor communication. It supports
> only one channel and work as either sender or receiver.
>
> Signed-off-by: Ley Foon Tan <lftan@...era.com>
>
> ---
> v2:
> Resolved comment from Dinh and Suman.
> - Alphabetize the headers.
> - Removed WARN_ON() checking
> - Use devm_kzalloc to allocate struct mbox_chan
> - Change __raw_readl/__raw_writel to readl/writel
> - Check interrupt mode before enable interrupt
> - Change to use module_platform_driver()
> - Remove platform_set_drvdata(pdev, NULL);
> - Fix "Alignment should match open parenthesis" warning
> - Update MAINTAINERS file
> ---

Any further feedback for this v2 patch?

Thanks.

Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/