linux-kernel - Re: xen/x86: properly retrieve NMI reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 06 Jan 2015 08:53:16 +0000
From:	"Jan Beulich" <jbeulich@...e.com>
To:	<david.vrabel@...rix.com>, <boris.ostrovsky@...cle.com>,
	<konrad.wilk@...cle.com>
Cc:	<xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>
Subject: Re: xen/x86: properly retrieve NMI reason

>>> David Vrabel <david.vrabel@...rix.com> 01/05/15 11:35 AM >>>
>On 19/12/14 16:16, Jan Beulich wrote:
>> Using the native code here can't work properly, as the hypervisor would
>> normally have cleared the two reason bits by the time Dom0 gets to see
>> the NMI (if passed to it at all). There's a shared info field for this,
>> and there's an existing hook to use - just fit the two together. Note
>> that the hook can (and should) be used irrespective of whether being in
>> Dom0, as accessing port 0x61 in a DomU would be even worse, while the
>> shared info field would just hold zero all the time.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@...e.com>
>
>This doesn't build.
>
>In file included from
>/local/davidvr/work/k.org/tip/arch/x86/xen/enlighten.c:43:0:
>/local/davidvr/work/k.org/tip/include/xen/interface/nmi.h:44:1: warning:
>data definition has no type or storage class [enabled by default]
>/local/davidvr/work/k.org/tip/include/xen/interface/nmi.h:44:1: error:
>type defaults to ‘int’ in declaration of ‘DEFINE_XEN_GUEST_HANDLE’
>[-Werror=implicit-int]
>cc1: some warnings being treated as errors

Hmm, I can see why this happens (Linux renaming the macro from what
the canonical headers use), but I'll have to check why my build test didn't
catch this...

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/