linux-kernel - Re: [PATCH] btrfs: reada: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1501061141250.20601@twin.jikos.cz>
Date:	Tue, 6 Jan 2015 11:42:07 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	David Sterba <dsterba@...e.cz>
cc:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: reada: Remove unused function

On Mon, 5 Jan 2015, David Sterba wrote:

> > Remove the function btrfs_reada_detach() that is not used anywhere.
> > 
> > This was partially found by using a static code analysis program called cppcheck.
> > 
> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> 
> No please, this function is part of public readahead API and similar
> patch has been NACKed several times.

BTW how is this any kind of API for anybody, given it's not exported to 
modules?

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/