lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 06 Jan 2015 11:45:58 +0100 From: Lars-Peter Clausen <lars@...afoo.de> To: Arnd Bergmann <arnd@...db.de> CC: linux-kernel@...r.kernel.org, Ralf Baechle <ralf@...ux-mips.org>, dmaengine@...r.kernel.org, alsa-devel@...a-project.org, linux-mmc@...r.kernel.org, linux-mips@...ux-mips.org Subject: Re: [PATCH, RFC] MIPS: jz4740: use dma filter function On 01/05/2015 11:39 PM, Arnd Bergmann wrote: > As discussed on the topic of shmobile DMA today, jz4740 is the only > user of the slave_id field in dma_slave_config besides shmobile. This > use is really incompatible with the way that other drivers use the > dmaengine API, so we should get rid of it. Do you have a link to that discussion? > > This adds a trivial filter function that uses the filter param to > pass the dma type, and uses that in both drivers. In my opinion that's just from bad to worse. Using filter functions isn't that great in the first place. And using them to pass data from the consumer to the DMA provider is just a horrible abuse of the API. The patch also adds a platform dependency, so the drivers won't built with COMPILE_TEST anymore. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists