linux-kernel - RE: [V7 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <A765B125120D1346A63912DDE6D8B6315FF32A@NTXXIAMBX02.xacn.micron.com>
Date:	Tue, 6 Jan 2015 01:42:58 +0000
From:	Bean Huo 霍斌斌 (beanhuo) 
	<beanhuo@...ron.com>
To:	Brian Norris <computersforpeace@...il.com>,
	Marek Vasut <marex@...x.de>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>
CC:	"shijie8@...il.com" <shijie8@...il.com>,
	"geert+renesas@...der.be" <geert+renesas@...der.be>,
	"grmoore@...era.com" <grmoore@...era.com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [V7 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for
 Micron spi nor

>This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes.

>For Micron SPI NOR flash, enabling or disabling quad I/O protocol can be done By two methods, 
>which are to use EVCR(Enhanced Volatile Configuration Register) and the ENTER QUAD I/O MODE command.
>There is no difference between these two methods. Unfortunately, for some Micron spi nor flashes,
>there no ENTER Quad I/O command(35h),such as n25q064.But for all current Micron spi nor,
>if it support quad I/O mode, using EVCR definitely be supported. It is a recommended method to
>enable Quad I/O mode by EVCR, Quad I/O protocol bit 7.When EVCR bit 7 is reset to 0,the SPI NOR flash will operate in quad I/O mode.

>This patch has been tested on N25Q512A and MT25TL256BAA1ESF.Micron spi nor of spi_nor_ids[] table all support this method.

>Signed-off-by: bean huo <beanhuo@...ron.com>
>Acked-by: Marek Vasut <marex@...x.de>
>---
>v1-v2:
>	Modified to that capture wait_till_ready()
>	return value,if error,directly return its
>	the value.
> v2-v3:
>	Directly use the reurning error value of
>	read_reg and write_reg,instead of -EINVAL.
> v3-v4:
>	Modify commit logs that wraped into 80 columns.
> v4-v5:
>	Rebuild new patch based on latest linux-mtd.
> v5-v6:
>	Rebuild patch based on latest l2-mtd.
>	add some comments.
>	Add SPI_NOR_QUAD_READ flag in the spi_nor_ids[] for Micron spi nor.
> V6-v7:
>	Fixed up val with u8 in micron_quad_enable().
	
hi,maintainer

how about this patch,it has been updated to V7.
Please give some suggestions or if  can be accepted?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/