[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150105161412.44f53313e1d771dc9f968264@linux-foundation.org>
Date: Mon, 5 Jan 2015 16:14:12 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Kiran Raparthy <kiran.kumar@...aro.org>
Cc: linux-kernel@...r.kernel.org, Colin Cross <ccross@...roid.com>,
Jason Wessel <jason.wessel@...driver.com>,
kgdb-bugreport@...ts.sourceforge.net,
Android Kernel Team <kernel-team@...roid.com>,
John Stultz <john.stultz@...aro.org>,
Sumit Semwal <sumit.semwal@...aro.org>
Subject: Re: [RFC v4] debug: prevent entering debug mode on panic/exception.
On Tue, 23 Dec 2014 18:08:29 +0530 Kiran Raparthy <kiran.kumar@...aro.org> wrote:
> From: Colin Cross <ccross@...roid.com>
>
> debug: prevent entering debug mode on panic/exception.
>
> On non-developer devices, kgdb prevents the device from rebooting
> after a panic.
>
> Incase of panics and exceptions, to allow the device to reboot, prevent
> entering debug mode to avoid getting stuck waiting for the user to interact
> with debugger.
>
> To avoid entering the debugger on panic/exception without any extra
> configuration, panic_timeout is being used which can be set via
> /proc/sys/kernel/panic at run time and CONFIG_PANIC_TIMEOUT sets the default
> value.
>
> ...
>
hm. Why overload the meaning of panic_timeout in this fashion? If
someone is using kgdb and has panic_timeout set, they'll get quiet a
surprise.
Would it be cleaner/clearer to add some new standalone control for
this? One which is only present if CONFIG_KGDB.
We appear to have forgotten to document panic_timeout. Sigh.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists