linux-kernel - Re: [PATCH] Revert "tty: Fix pty master poll() after slave closes v2"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54ABF221.7000305@suse.cz>
Date:	Tue, 06 Jan 2015 15:33:05 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Peter Hurley <peter@...leysoftware.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Francesco Ruggeri <fruggeri@...stanetworks.com>,
	Francesco Ruggeri <fruggeri@...sta.com>
Subject: Re: [PATCH] Revert "tty: Fix pty master poll() after slave closes
 v2"

On 12/30/2014, 01:31 PM, Peter Hurley wrote:
> On 12/30/2014 07:17 AM, Peter Hurley wrote:
>> This reverts commit c4dc304677e8d566572c4738d95c48be150c6606.
>> This fix is superseded by commit 52bce7f8d4fc633c9a9d0646eef58ba6ae9a3b73,
>> 'pty, n_tty: Simplify input processing on final close'.
>>
>> The final close now waits for input processing to complete before
>> destroying the pty, so poll() does not need to special case this
>> condition.
> 
> Greg,
> 
> As noted in this commit log, commit c4dc304677e8d566572c4738d95c48be150c6606,
> 'tty: Fix pty master poll() after slave closes v2', is not required
> after commit 52bce7f8d4fc633c9a9d0646eef58ba6ae9a3b73,
> 'pty, n_tty: Simplify input processing on final close'
> 
> However, 'tty: Fix pty master poll() after slave closes v2' is appropriate
> for stable back to v3.12.

Now applied to 3.12. A backport was needed due to the later change of
the input_available_p 2nd parameter.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/