linux-kernel - Re: [PATCH V3 2/2] mm, vmscan: wake up all pfmemalloc-throttled processes at once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54AB4F3F.50103@redhat.com>
Date:	Mon, 05 Jan 2015 21:58:07 -0500
From:	Rik van Riel <riel@...hat.com>
To:	Vlastimil Babka <vbabka@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org
CC:	linux-kernel@...r.kernel.org, Mel Gorman <mgorman@...e.de>,
	Johannes Weiner <hannes@...xchg.org>,
	Michal Hocko <mhocko@...e.cz>,
	Vladimir Davydov <vdavydov@...allels.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH V3 2/2] mm, vmscan: wake up all pfmemalloc-throttled processes
 at once

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/05/2015 03:56 AM, Vlastimil Babka wrote:
> Kswapd in balance_pgdate() currently uses wake_up() on processes
> waiting in throttle_direct_reclaim(), which only wakes up a single
> process. This might leave processes waiting for longer than
> necessary, until the check is reached in the next loop iteration.
> Processes might also be left waiting if zone was fully balanced in
> single iteration. Note that the comment in balance_pgdat() also
> says "Wake them", so waking up a single process does not seem
> intentional.
> 
> Thus, replace wake_up() with wake_up_all().
> 
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz> Cc: Mel Gorman
> <mgorman@...e.de> Cc: Johannes Weiner <hannes@...xchg.org> Cc:
> Michal Hocko <mhocko@...e.cz> Cc: Vladimir Davydov
> <vdavydov@...allels.com> Cc: Rik van Riel <riel@...hat.com>

Acked-by: Rik van Riel <riel@...hat.com>

- -- 
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUq08+AAoJEM553pKExN6D9bEIAKV916k0OguiyAGIXrgjPrba
3W2eQ2FFWIm6KwumPas7t6jBzR11yFhpAIACf6nNt12EmH73UwaW2z6vdYque4c+
HU79DXTNTQ91xJfXI8XfNsZW/s8zpCZ+Sm08N7/O7k6c76yKR+owXmoSnjb2Q4N9
O0F0db3Jkd52sH/2l+LCUKrTeI9fRBrKnpAv7FAhZ5go8N7tdtIjYv8hhpIZ/83F
WSRsORt0VKOx0an+JO09e5f6R+RF7RAqiU6yUdDAk52CJzyRqECksLxDOvw81OHD
QUT5TuMVNoqXNJxFpQvyI8Dn82d1CiisX2Wztcic4OlxPJQ6gK04SmeWMXw8Ijw=
=pnD6
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/