linux-kernel - Re: [PATCH] tools: testing: selftests: mq_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54AC3F80.5060406@osg.samsung.com>
Date:	Tue, 06 Jan 2015 13:03:12 -0700
From:	Shuah Khan <shuahkh@....samsung.com>
To:	dann frazier <dann.frazier@...onical.com>,
	linux-api@...r.kernel.org
CC:	linux-kernel@...r.kernel.org, Shuah Khan <shuah.kh@...sung.com>,
	Doug Ledford <dledford@...hat.com>
Subject: Re: [PATCH] tools: testing: selftests: mq_perf_tests: Fix infinite
 loop on ARM

On 01/05/2015 07:54 PM, dann frazier wrote:
> We can't use a char type to check for a negative return value since char
> isn't guaranteed to be signed. Indeed, the char type tends to be unsigned on
> ARM.
> 
> Signed-off-by: dann frazier <dann.frazier@...onical.com>
> ---
>  tools/testing/selftests/mqueue/mq_perf_tests.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c
> index 94dae65..8519e9e 100644
> --- a/tools/testing/selftests/mqueue/mq_perf_tests.c
> +++ b/tools/testing/selftests/mqueue/mq_perf_tests.c
> @@ -536,10 +536,9 @@ int main(int argc, char *argv[])
>  {
>  	struct mq_attr attr;
>  	char *option, *next_option;
> -	int i, cpu;
> +	int i, cpu, rc;
>  	struct sigaction sa;
>  	poptContext popt_context;
> -	char rc;
>  	void *retval;
>  
>  	main_thread = pthread_self();
> 

Thanks. Applied to kernel/git/shuah/linux-kselftest fixes branch

-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/