linux-kernel - Re: [PATCH v2 26/40] arch/sparc: uaccess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150106214407.GA15535@redhat.com>
Date:	Tue, 6 Jan 2015 23:44:07 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	linux-arch@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>, sparclinux@...r.kernel.org
Subject: Re: [PATCH v2 26/40] arch/sparc: uaccess_64 macro whitespace fixes

On Tue, Jan 06, 2015 at 09:46:07PM +0100, Sam Ravnborg wrote:
> > > sparc64: fix coding style in uaccess_64.h
> > 
> > OK.
> > I see David reviewed and sent acks, so I won't bother
> > reposting, but I'll tweak this in my tree.
> OK.
> 
> > > > I get it you like it that 
> > > > 	case 1: __get_user_asm(__gu_val,ub,addr,__gu_ret); break;
> > > > has the whole case on the same line?
> > > > Is that the issue?
> > > Exactly - much easier to read this way.
> > > That the "\" was not aligned in these parts of the code did not help either.
> > > 
> > > 	Sam
> > 
> > I see David acked this already - I'll do a patch on top to tweak just
> > these two places to your liking?
> 
> Thanks.

OK, sent.
Mind sending acks for these and the original patches?
You can add that your ack is conditional on applying the tweak on top.

> When you have done so please wait for David's ack before you
> sent then upstream. That I like it does not make it universally accepted.
> 
> 	Sam

Sure.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/