[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150106060226.GA4285@sudip-PC>
Date: Tue, 6 Jan 2015 11:32:26 +0530
From: Sudip Mukherjee <sudipm.mukherjee@...il.com>
To: Piotr Kubus <p.t.kubus@...il.com>
Cc: Konrad Zapalowicz <bergo.torino@...il.com>,
gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
abbotti@....co.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue
On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote:
> On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote:
> > On 01/04, Piotr Kubus wrote:
> > > This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.
> >
> > Nice however improve your commit message. The rule is that the lines
> > should wrap at 72nd column except for quoted material such as compiler
> > output, etc...
> >
> > The 72-character columns are important for allowing quoting and they
> > play nicely with standard indentation from git log.
>
> Hey,
>
> I couldn't find that rule in Kernel documentation. Besides there were no
> complaints from checkpatch.pl tool.
Please check SubmittingPatches in Documentation. It says:
'the "summary" must be no more than 70-75 characters'
thanks
sudip
> Piotr
>
> >
> > Thanks,
> > Konrad
> >
<snip>
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists