linux-kernel - Re: [PATCH RESEND 3/3] Documentation: Add documentation for rt5033 multifunction device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqL5UkxkX8hUHvQzFAT8JhGEj-eZLcmxJ4goUMo39_UOEA@mail.gmail.com>
Date:	Tue, 6 Jan 2015 18:02:05 -0600
From:	Rob Herring <robherring2@...il.com>
To:	Beomho Seo <beomho.seo@...sung.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	lee.jone@...aro.org, Mark Brown <broonie@...nel.org>,
	Sebastian Reichel <sre@...nel.org>, dbaryshkov@...il.com,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	InKi Dae <inki.dae@...sung.com>, sw0312.kim@...sung.com,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH RESEND 3/3] Documentation: Add documentation for rt5033
 multifunction device

On Tue, Jan 6, 2015 at 5:34 PM, Beomho Seo <beomho.seo@...sung.com> wrote:
> Thank you for review.
>
> On 01/07/2015 01:54 AM, Rob Herring wrote:
>> On Mon, Jan 5, 2015 at 11:45 PM, Beomho Seo <beomho.seo@...sung.com> wrote:
>>> This patch device tree binding documentation for rt5033 multifunction device.

[...]

>>> +               compatible = "i2c-gpio";
>>> +               standard i2c-gpio constraints...
>>> +               fuelgauge {
>>> +                       compatible = "richtek,rt5033-battery".
>>> +               };
>>> +       };
>>
>> I'm a bit confused by this. The fuelgauge is an i2c device hanging off
>> the rt5033 or a 2nd i2c slave on the rt5033?
>>
>
> It is 2nd i2c slave on the rt5033.

Okay, then you should leave out i2c-gpio from the example. The type of
i2c host is not relevant. You could for example have both slaves
attached to the same master. So just this (at the same level as
rt5033@34)

rt5033@35 {
        compatible = "richtek,rt5033-battery";
        interrupt-parent = <&gpx2>;
        interrupts = <3 0>;
        reg = <0x35>;
};

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/