linux-kernel - Re: [PATCH 2/2][RFC] ipmi: Update timespec usage to timespec64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLUKxP98bc0w_15_CLhGkmFsT-3d++3U6r_+fpuKTBpfSA@mail.gmail.com>
Date:	Wed, 7 Jan 2015 13:22:56 -0800
From:	John Stultz <john.stultz@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Corey Minyard <minyard@....org>,
	openipmi-developer <openipmi-developer@...ts.sourceforge.net>
Subject: Re: [PATCH 2/2][RFC] ipmi: Update timespec usage to timespec64

On Wed, Jan 7, 2015 at 1:12 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Wednesday 07 January 2015 12:51:50 John Stultz wrote:
>> As part of the internal y2038 cleanup, this patch removes
>> timespec usage in the ipmi driver, replacing it timespec64
>>
>> Cc: Corey Minyard <minyard@....org>
>> Cc: openipmi-developer@...ts.sourceforge.net
>> Cc: Arnd Bergmann <arnd@...db.de>
>> Signed-off-by: John Stultz <john.stultz@...aro.org>
>>
>
> In other drivers, we tended to use ktime_t and monotonic time,
> but your approach is definitely simpler because it doesn't have
> to rework the ipmi_si_is_busy logic and just do a
> s/timespec/timespec64/ conversion.
>
> Do you think it makes sense to use ktime_get_ts64 instead of
> getnstimeofday64 to get a monotonic time? The advantage would
> be to have the code work slightly better when racing against
> settimeofday, the downside would be that the debug printk
> shows the changed time base, but that would hopefully be
> irrelevant to someone debugging the code.

So here they were explicitly printing wall-time in sec/usec, so I was
somewhat hoping not to create any major behavioral changes.

But looking at this again, I see I sent a stale patch which has a
build bug (using tv_usec w/ a timespec64)... so let me redo this
anyway.

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/