linux-kernel - Re: [PATCH] mm: move MACRO SLAB_NEVER_MERGE and SLAB_MERGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1501062114240.5674@gentwo.org>
Date:	Tue, 6 Jan 2015 21:16:51 -0600 (CST)
From:	Christoph Lameter <cl@...ux.com>
To:	Bryton Lee <brytonlee01@...il.com>
cc:	iamjoonsoo.kim@....com, penberg@...nel.org, rientjes@...gle.com,
	akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	"vger.linux-kernel.cn" <kernel@...r.linux-kernel.cn>
Subject: Re: [PATCH] mm: move MACRO SLAB_NEVER_MERGE and SLAB_MERGE_SAME to
 file linux/slab.h

On Wed, 7 Jan 2015, Bryton Lee wrote:

> move MACRO SLAB_NEVER_MERGE and SLAB_MERGE_SAME from file mm/slab_common.c
> to file linux/slab.h.
> let other kernel code create slab can use these flags.

This does not make sense. The fact that a slab has been merged is
available from a field in the kmem_cache structure (aliases).


These two macros are criteria for the slab allocators to perform merges.
The merge decision is the slab allocators decision and not the decision of
other kernel code.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/