linux-kernel - [PATCH] writeback: fix simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Jan 2015 12:25:35 +0800
From:	kbuild test robot <fengguang.wu@...el.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	kbuild-all@...org, Jens Axboe <axboe@...nel.dk>,
	Jan Kara <jack@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Memory Management List <linux-mm@...ck.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Maxim Patlasov <MPatlasov@...allels.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Derek Basehore <dbasehore@...omium.org>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] writeback: fix simple_return.cocci warnings

mm/backing-dev.c:513:1-4: WARNING: end returns can be simpified and declaration on line 502 can be dropped

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

 backing-dev.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -499,8 +499,6 @@ static void bdi_wb_exit(struct bdi_write
 
 int bdi_init(struct backing_dev_info *bdi)
 {
-	int err;
-
 	bdi->dev = NULL;
 
 	bdi->min_ratio = 0;
@@ -510,11 +508,7 @@ int bdi_init(struct backing_dev_info *bd
 	INIT_LIST_HEAD(&bdi->bdi_list);
 	INIT_LIST_HEAD(&bdi->work_list);
 
-	err = bdi_wb_init(&bdi->wb, bdi);
-	if (err)
-		return err;
-
-	return 0;
+	return bdi_wb_init(&bdi->wb, bdi);
 }
 EXPORT_SYMBOL(bdi_init);
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/