lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 6 Jan 2015 20:53:19 -0800
From:	Linus Torvalds <>
To:	Vlastimil Babka <>
Cc:	Andrew Morton <>,
	linux-mm <>,
	Linux Kernel Mailing List <>,
	"Aneesh Kumar K.V" <>,
	David Rientjes <>,
	Johannes Weiner <>,
	Joonsoo Kim <>,
	"Kirill A. Shutemov" <>,
	Mel Gorman <>, Michal Hocko <>,
	Minchan Kim <>,
	Rik van Riel <>,
	Zhang Yanfei <>
Subject: Re: [PATCH V3 0/4] Reducing parameters of alloc_pages* family of functions

On Mon, Jan 5, 2015 at 8:01 AM, Vlastimil Babka <> wrote:
> Hm, nope. The !CONFIG_COMPACTION variant of try_to_compact_pages() is static
> inline that returns COMPACT_CONTINUE, which is defined in compaction.h.
> Another solution is to add a "forward" declaration (not actually followed later
> by a full definition) of struct alloc_context into compaction.h. Seems to work
> here, but I'm not sure if such thing is allowed?

We do forward struct declarations quite often (well, _relatively_
often) in order to avoid nasty circular header includes, and sometimes
just to avoid unnecessarily many header includes.

See for example

    git grep '\<struct [a-zA-Z_0-9]*;'

it's not exactly rare.

So it's fine.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists