linux-kernel - Re: [PATCH] s390: crypto: aes_s390: Remove 'const' to avoid compiler warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150107082414.GA4365@osiris>
Date:	Wed, 7 Jan 2015 09:24:14 +0100
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Chen Gang <gang.chen@...rus.com.cn>
Cc:	herbert@...dor.apana.org.au, davem@...emloft.net,
	schwidefsky@...ibm.com, linux390@...ibm.com,
	linux-crypto@...r.kernel.org, linux-s390@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] s390: crypto: aes_s390: Remove 'const' to avoid compiler
 warnings

On Thu, Jan 01, 2015 at 10:56:02PM +0800, Chen Gang wrote:
> In aes_encrypt() and aes_decrypt(), need let 'sctx->key' be modified,
> so remove 'const' for it. The related warnings:
...
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> ---
>  arch/s390/crypto/aes_s390.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/crypto/aes_s390.c b/arch/s390/crypto/aes_s390.c
> index 1f272b2..5566ce8 100644
> --- a/arch/s390/crypto/aes_s390.c
> +++ b/arch/s390/crypto/aes_s390.c
> @@ -134,7 +134,7 @@ static int aes_set_key(struct crypto_tfm *tfm, const u8 *in_key,
> 
>  static void aes_encrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
>  {
> -	const struct s390_aes_ctx *sctx = crypto_tfm_ctx(tfm);
> +	struct s390_aes_ctx *sctx = crypto_tfm_ctx(tfm);
> 
>  	if (unlikely(need_fallback(sctx->key_len))) {
>  		crypto_cipher_encrypt_one(sctx->fallback.cip, out, in);
> @@ -159,7 +159,7 @@ static void aes_encrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
> 
>  static void aes_decrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
>  {
> -	const struct s390_aes_ctx *sctx = crypto_tfm_ctx(tfm);
> +	struct s390_aes_ctx *sctx = crypto_tfm_ctx(tfm);
> 
>  	if (unlikely(need_fallback(sctx->key_len))) {
>  		crypto_cipher_decrypt_one(sctx->fallback.cip, out, in);

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/