linux-kernel - Re: [PATCH] mfd: syscon: fix syscon probing from dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1420624699.3191.19.camel@pengutronix.de>
Date:	Wed, 07 Jan 2015 10:58:19 +0100
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Arnd Bergmann <arnd@...db.de>,
	Pankaj Dubey <pankaj.dubey@...sung.com>,
	Tomasz Figa <tomasz.figa@...il.com>,
	linux-kernel@...r.kernel.org,
	Vivek Gautam <gautam.vivek@...sung.com>, kernel@...gutronix.de,
	Lee Jones <lee.jones@...aro.org>,
	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Subject: Re: [PATCH] mfd: syscon: fix syscon probing from dt

Hi Heiko,

Am Dienstag, den 06.01.2015, 20:05 +0100 schrieb Heiko Stübner:
> Hi Philipp,
> 
> Am Dienstag, 6. Januar 2015, 16:30:36 schrieb Philipp Zabel:
> > Patch bdb0066df96e ("mfd: syscon: Decouple syscon interface from platform
> > devices") breaks probing pure syscon devices from device tree, such as
> > anatop and iomuxc-gpr on i.MX. This patch adds back the dt id table to
> > match against "syscon" compatible device tree nodes.
> 
> could you elaborate a bit on the problem you're seeing without your patch?
>
> With bdb0066df96e the syscon should be registered by the first call to one of 
> the syscon_regmap_lookup_by_* functions. On my rockchip boards this works 
> without any hickups:

Oh, I didn't understand that is the way it's supposed to work now.

I noticed that after booting v3.19-rc on a nitrogen6x, the
/sys/kernel/debug/regmap/{20c8000.anatop,20e0000.iomuxc-gpr}
directories were missing. The syscon regmap is indeed registered,
but since regmap_init_mmio is called with dev = NULL, regmap_attach_dev,
and thus regmap_debugfs_init, is never called from regmap_init.

Also I want to add child devices to the syscon device since a while ago:
https://lkml.org/lkml/2014/12/15/133
This doesn't work anymore if there is no syscon device.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/