linux-kernel - Re: [PATCH 3/5] perf diff: Print diff result more precisely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cjQ=SW6nMoT3t-2JUvcxXta2B=imRXU6SvdM21joyfwMQ@mail.gmail.com>
Date:	Wed, 7 Jan 2015 23:02:49 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 3/5] perf diff: Print diff result more precisely

On Mon, Jan 5, 2015 at 1:47 AM, Jiri Olsa <jolsa@...hat.com> wrote:
> On Sat, Dec 27, 2014 at 02:06:31PM +0900, Namhyung Kim wrote:
>> Current perf diff result is somewhat confusing since it sometimes hide
>> small result and sometimes there's no result.  So do not hide small
>> result (less than 0.01%) and print "N/A" if baseline is not
>> recorded (for ratio and wdiff only).  Blank means the baseline is
>> available but its pairs are not.
>
> I think we should document this, especialy when diff has different
> behaviour from the rest of the computation.. :-\

Well, probably I'm missing something but I don't know what needs to be
documented.  Currently perf diff doesn't show small result so it's
hard to distinguish entries that have small result and no result.  But
to sort the output properly, it needs to show the results and I think
it's natural to not hide the result to user.


>
> anyway for the change itself:
>
> Acked-by: Jiri Olsa <jolsa@...nel.org>

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/