linux-kernel - Re: [PATCH] x86/xen: Free bootmem in free_p2m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54AD4167.8020703@suse.com>
Date:	Wed, 07 Jan 2015 15:23:35 +0100
From:	Juergen Gross <jgross@...e.com>
To:	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	david.vrabel@...rix.com, konrad.wilk@...cle.com
CC:	xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/xen: Free bootmem in free_p2m_page() during early
 boot

On 01/07/2015 03:08 PM, Boris Ostrovsky wrote:
> With recent changes in p2m we now have legitimate cases when
> p2m memory needs to be freed during early boot (i.e. before
> slab is initialized).
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>

Reviewed-by: Juergen Gross <jgross@...e.com>

> ---
>   arch/x86/xen/p2m.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
> index edbc7a6..df8acb4 100644
> --- a/arch/x86/xen/p2m.c
> +++ b/arch/x86/xen/p2m.c
> @@ -167,10 +167,13 @@ static void * __ref alloc_p2m_page(void)
>   	return (void *)__get_free_page(GFP_KERNEL | __GFP_REPEAT);
>   }
>
> -/* Only to be called in case of a race for a page just allocated! */
>   static void free_p2m_page(void *p)
>   {
> -	BUG_ON(!slab_is_available());
> +	if (unlikely(!slab_is_available())) {
> +		free_bootmem((unsigned long)p, PAGE_SIZE);
> +		return;
> +	}
> +
>   	free_page((unsigned long)p);
>   }
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/