linux-kernel - Re: [PATCH] coresight: fix return value judgement in of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANLsYkxRfSAmevU3dqQVXvQAJVrChYVdG=+vKTtUo84e+SLG7A@mail.gmail.com>
Date:	Wed, 7 Jan 2015 08:27:42 -0700
From:	Mathieu Poirier <mathieu.poirier@...aro.org>
To:	Kaixu Xia <xiakaixu@...wei.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kaixu Xia <kaixu.xia@...aro.org>
Subject: Re: [PATCH] coresight: fix return value judgement in of_coresight.c

On 7 January 2015 at 02:31, Kaixu Xia <xiakaixu@...wei.com> wrote:
> The right return value is rdev, so we should judge it.
>
> Signed-off-by: Kaixu Xia <xiakaixu@...wei.com>
> ---
>  drivers/coresight/of_coresight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/coresight/of_coresight.c b/drivers/coresight/of_coresight.c
> index 5030c07..5b5f188 100644
> --- a/drivers/coresight/of_coresight.c
> +++ b/drivers/coresight/of_coresight.c
> @@ -174,7 +174,7 @@ struct coresight_platform_data *of_get_coresight_platform_data(
>                                 continue;
>
>                         rdev = of_coresight_get_endpoint_device(rparent);
> -                       if (!dev)
> +                       if (!rdev)
>                                 continue;
>
>                         pdata->child_names[i] = dev_name(rdev);
> --
> 1.8.5.5
>

Applied with re-factoring of the commit subject line and log message.  Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/