linux-kernel - Re: [PATCH v2] irqchip: mediatek: Use IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150107020814.GA24989@titan.lakedaemon.net>
Date:	Tue, 6 Jan 2015 21:08:14 -0500
From:	Jason Cooper <jason@...edaemon.net>
To:	Yingjoe Chen <yingjoe.chen@...iatek.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Beniamino Galvani <b.galvani@...il.com>,
	Marc Zyngier <marc.zyngier@....com>,
	srv_heupstream@...iatek.com, hc.yen@...iatek.com,
	yh.chen@...iatek.com, linux-kernel@...r.kernel.org,
	Matthias Brugger <matthias.bgg@...il.com>,
	nathan.chung@...iatek.com, Sascha Hauer <kernel@...gutronix.de>,
	eddie.huang@...iatek.com, yingjoe.chen@...il.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] irqchip: mediatek: Use IS_ERR() instead of NULL
 pointer check

Yingjoe,

On Wed, Dec 10, 2014 at 05:55:02PM +0800, Yingjoe Chen wrote:
> Beniamino reported a kernel oops caused by an invalid DT file for the
> mediatek interrupt polarity extension.
> 
> The reason is that the interrupt polarity support for mediatek chips
> merely checks for NULL pointer instead of a casted error return
> value in mtk_sysirq_of_init() so any other casted error value passes
> the NULL pointer check and causes a kernel panic when dereferenced.
> 
> Use IS_ERR() and return the error value via PTR_ERR().
> 
> Reported-and-tested-by: Beniamino Galvani <b.galvani@...il.com>
> Signed-off-by: Yingjoe Chen <yingjoe.chen@...iatek.com>
> ---
>  drivers/irqchip/irq-mtk-sysirq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I applied V2 to irqchip/urgent, and hand-added the changes from V3
because the email formatting was wrong.  I also tweaked the subject
line.

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/