linux-kernel - Re: [PATCH v4] bcma: fix two coding style issues, more than 80 characters per line.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 07 Jan 2015 20:39:44 +0200
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	Oscar Forner Martinez <oscar.forner.martinez@...il.com>,
	"linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] bcma: fix two coding style issues, more than 80 characters per line.

Rafał Miłecki <zajec5@...il.com> writes:

> On 7 January 2015 at 18:55, Kalle Valo <kvalo@...eaurora.org> wrote:
>> Oscar Forner Martinez <oscar.forner.martinez@...il.com> writes:
>>
>>> Two lines with more than 80 characters per line have been split in several lines.
>>>
>>> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@...il.com>
>>
>> Thanks, applied to wireless-drivers-next.git.
>
> Could you still replace it (V4) with an older version (V3)? Before I
> explained V3 was OK Oscar already sent this (worse) V4.

No. I'm not going to rebase a public git tree unless there's a huge
disaster.

But if I see V4 I'm going to assume that's the one I need to apply, not
some older version. If V4 is not good for some reason, make it
ABSOLUTELY clear that I should not apply it. I do not want to start
guessing what patch I should apply.

> This is not critical though, we can always send separated patch for
> one more line > 80 chars.

Please send a followup patch if you want to fix something.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/