linux-kernel - RE: [PATCH 3/3] mtd: spi-nand: add devicetree binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87F60714EC601C4C83DFF1D2E3D390A04AB4EA@NTXXIAMBX02.xacn.micron.com>
Date:	Thu, 8 Jan 2015 05:04:24 +0000
From:	Peter Pan 潘栋 (peterpandong) 
	<peterpandong@...ron.com>
To:	Ezequiel Garcia <ezequiel.garcia@...tec.com>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"Brian Norris" <computersforpeace@...il.com>
CC:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Qi Wang 王起 (qiwang) <qiwang@...ron.com>,
	Frank Liu 刘群 (frankliu) 
	<frankliu@...ron.com>,
	Melanie Zhang 张燕 (melaniezhang) 
	<melaniezhang@...ron.com>
Subject: RE: [PATCH 3/3] mtd: spi-nand: add devicetree binding

> > This commit adds the devicetree binding document that specifies the
> > spi nand devices support.
> >
> > Signed-off-by: Peter Pan <peterpandong@...ron.com>
> > ---
> >  Documentation/devicetree/bindings/mtd/spi-nand.txt | 22
> ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mtd/spi-
> nand.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/spi-nand.txt
> b/Documentation/devicetree/bindings/mtd/spi-nand.txt
> > new file mode 100644
> > index 0000000..9dd3efd
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/spi-nand.txt
> > @@ -0,0 +1,22 @@
> > +* NAND driver for MT29F, GD5F and similar SPI NAND flash chips
> > +
> > +Required properties:
> > +- #address-cells, #size-cells : Must be present if the device has
> sub-nodes
> > +  representing partitions.
> > +- compatible : Should be the manufacturer and the name of the chip.
> Bear in mind
> >
> 
> Unless I'm mistaken, we don't need the chip ID here, as SPI NAND allows
> to autodetect the device. Any reason why we can't just use a generic
> compatible "spi-nand" here?
> --
> Ezequiel

In fact, I don't know how to autodetect the SPI NAND device. Micron device and
Gigadevice device have different read ID functions. The Chip ID here is used to
determine which function to use.


Peter Pan