[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150108080829.GA12425@redhat.com>
Date: Thu, 8 Jan 2015 10:08:29 +0200
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc: linux-kernel@...r.kernel.org,
Alex Williamson <alex.williamson@...hat.com>,
Greg Kurz <gkurz@...ux.vnet.ibm.com>, kvm@...r.kernel.org,
virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH] vhost/net: length miscalculation
On Wed, Jan 07, 2015 at 11:58:00PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 01/07/2015 11:55 AM, Michael S. Tsirkin wrote:
>
> >commit 8b38694a2dc8b18374310df50174f1e4376d6824
> > vhost/net: virtio 1.0 byte swap
> >had this chunk:
> >- heads[headcount - 1].len += datalen;
> >+ heads[headcount - 1].len = cpu_to_vhost32(vq, len - datalen);
>
> >This adds datalen with the wrong sign, causing guest panics.
>
> >Fixes: 8b38694a2dc8b18374310df50174f1e4376d6824
>
> The format of this tag assumes 12-digit SHA1 hash and the commit
> description enclosed in parens and double quotes. See
> Documentation/SubmittingPatches.
>
> >Reported-by: Alex Williamson <alex.williamson@...hat.com>
> >Suggested-by: Greg Kurz <gkurz@...ux.vnet.ibm.com>
> >Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
>
> WBR, Sergei
I pushed the patches to Linus unfortunately - there's
some urgency since many people are hitting the bug.
Will do my best to do it right next time.
--
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists