linux-kernel - Re: [PATCH 2/3] mm/compaction: add more trace to understand compaction start/finish condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54AE4424.3070406@suse.cz>
Date:	Thu, 08 Jan 2015 09:47:32 +0100
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Joonsoo Kim <iamjoonsoo.kim@....com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>,
	David Rientjes <rientjes@...gle.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] mm/compaction: add more trace to understand compaction
 start/finish condition

On 01/08/2015 09:21 AM, Joonsoo Kim wrote:
> 
> Okay. How about adding one more like below?
> 
> #define COMPACT_NO_SUITABLE_PAGE
> #define COMPACT_NOT_SUITABLE_ZONE

Yeah that would be less confusing.

> It will distiguish return value properly.
> 
>> >  	return COMPACT_CONTINUE;
>> >  }
>> >  
>> > +unsigned long compaction_suitable(struct zone *zone, int order,
>> > +					int alloc_flags, int classzone_idx)
>> > +{
>> > +	unsigned long ret;
>> > +
>> > +	ret = __compaction_suitable(zone, order, alloc_flags, classzone_idx);
>> > +	trace_mm_compaction_suitable(zone, order, alloc_flags,
>> > +						classzone_idx, ret);
>> > +	if (ret == COMPACT_NOT_SUITABLE)
>> > +		ret = COMPACT_SKIPPED;
>> 
>> I don't like this wrapping just for tracepints, but I don't know of a better way :/
> 
> Yes, I don't like it, too. :/
> 
> Thanks.
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/