[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-id: <54AE61F6.808@samsung.com>
Date: Thu, 08 Jan 2015 11:54:46 +0100
From: Andrzej Hajda <a.hajda@...sung.com>
To: Andi Kleen <andi@...stfloor.org>, Andreas Mohr <andi@...as.de>
Cc: linux-mm@...ck.org, Marek Szyprowski <m.szyprowski@...sung.com>,
linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 0/4] kstrdup optimization
Hi Andi, Andreas,
Thanks for comments.
On 12/30/2014 10:29 PM, Andi Kleen wrote:
>> This symmetry issue probably could be cleanly avoided only
>> by having kfree() itself contain such an identifying check, as you suggest
>> (thereby slowing down kfree() performance).
>
> It actually shouldn't slow it down. kfree already complains if you free
> a non slab page, this could be just in front of the error check.
>
> The bigger concern is that it may hide some programing errors elsewhere
> though. So it's probably better to keep it a separate function.
Shall I interpret it as preliminary ack?
If yes, I can repost it without RFC prefix. Anyway I need to:
- add EXPORT_SYMBOL(kstrdup_const),
- add kerneldocs for both functions.
I can also add patch constifying mnt->mnt_devname in alloc_vfsmnt,
on my test platform it could save 13 additional allocations.
Regards
Andrzej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists