[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <54AE78C9.9010308@redhat.com>
Date: Thu, 08 Jan 2015 13:32:09 +0100
From: Paolo Bonzini <pbonzini@...hat.com>
To: Andrej Manduch <amanduch@...il.com>,
Nicholas Krause <xerofoify@...il.com>, gleb@...nel.org
CC: x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] arch:x86:kvm:Add function for setting pending timer
on virtual cpu in x86.c
On 08/01/2015 13:15, Andrej Manduch wrote:
>>> >> - /* FIXME: this code should not know anything about vcpus */
> I don't want to sounds like I'm nitpicking. But I need to ask. Why is
> this comment removed?
Because the real point of the comment was that the code should not know
anything about VCPU requests. But it's okay to call a function to tell
the VCPU "we want you to call us back at kvm_inject_apic_timer_irqs".
Paolo
>>> >> - kvm_make_request(KVM_REQ_PENDING_TIMER, vcpu);
>>> >> + kvm_set_pending_timer(vcpu);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists