[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <54AE9604.4040901@citrix.com>
Date: Thu, 8 Jan 2015 14:36:52 +0000
From: David Vrabel <david.vrabel@...rix.com>
To: Vitaly Kuznetsov <vkuznets@...hat.com>, <x86@...nel.org>
CC: Andrew Jones <drjones@...hat.com>, <linux-kernel@...r.kernel.org>,
Ingo Molnar <mingo@...hat.com>,
David Vrabel <david.vrabel@...rix.com>,
"H. Peter Anvin" <hpa@...or.com>, <xen-devel@...ts.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@...cle.com>,
Laszlo Ersek <lersek@...hat.com>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [Xen-devel] [PATCH v2] x86/xen: avoid freeing static 'name' when
kasprintf() fails
On 05/01/15 15:27, Vitaly Kuznetsov wrote:
> In case kasprintf() fails in xen_setup_timer() we assign name to the static
> string "<timer kasprintf failed>". We, however, don't check that fact before
> issuing kfree() in xen_teardown_timer(), kernel is supposed to crash with
> 'kernel BUG at mm/slub.c:3341!'
>
> Solve the issue by making name a fixed length string inside struct
> xen_clock_event_device. 16 bytes should be enough.
Applied to stable/for-linus-3.19, thanks.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists