linux-kernel - Re: [RFC] usb: dwc3: add DWC3_SKIP_USB3PHY and DWC3_SKIP_USB2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150108170815.GJ31926@saruman>
Date:	Thu, 8 Jan 2015 11:08:15 -0600
From:	Felipe Balbi <balbi@...com>
To:	Jisheng Zhang <jszhang@...vell.com>
CC:	<balbi@...com>, <linux-usb@...r.kernel.org>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [RFC] usb: dwc3: add DWC3_SKIP_USB3PHY and DWC3_SKIP_USB2_PHY
 quirks

Hi,

On Mon, Dec 08, 2014 at 09:35:51PM +0800, Jisheng Zhang wrote:
> On platforms which has native usb hosts/phys and pci-dwc3 controller,
> the dwc3 core may get the wrong usb2_phy and usb3_phy by
> devm_usb_get_phy(). It depends on which usb phy driver is initialized
> firstly, the usb_phy_generic or the native/real usb phy driver.

why are you initializing generic PHY if you have a real PHY ?

> Before all old USB phy library usage removed, the solution I can have
> is to add DWC3_SKIP_USB3PHY and DWC3_SKIP_USB2_PHY quirks and set them
> in dwc3-pci.
> Could such modification can be accepted? If not, could you please give
> alternative suggestions?

we will not accept a quirk to skip PHYs, sorry. A better way of handling
this needs to be found.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)