linux-kernel - Re: [PATCH 1/2] clk: Add clk_unregister_{divider,gate,mux} to close memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 08 Jan 2015 13:22:42 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Mike Turquette <mturquette@...aro.org>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Tomasz Figa <tomasz.figa@...il.com>,
	Kukjin Kim <kgene@...nel.org>, linux-kernel@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] clk: Add clk_unregister_{divider,gate,mux} to close
 memory leak

On 01/05/2015 01:52 AM, Krzysztof Kozlowski wrote:
> The common clk_register_{divider,gate,mux} functions allocated memory
> for internal data which wasn't freed anywhere. Drivers using these
> helpers could only unregister clocks but the memory would still leak.
>
> Add corresponding unregister functions which will release all resources.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> ---

We're trying to move away from struct clk in provider APIs. It would be
nice to have these functions take the clk_hw pointer instead, but I
guess that can come later.

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/