linux-kernel - RE: [PATCH] net: fec: Fix dual ethernet issue in VFxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BLUPR03MB373C95CD17B1CBBCE2DF72EF5440@BLUPR03MB373.namprd03.prod.outlook.com>
Date:	Fri, 9 Jan 2015 08:43:29 +0000
From:	"fugang.duan@...escale.com" <fugang.duan@...escale.com>
To:	Stefan Agner <stefan@...er.ch>
CC:	Bhuvanchandra DV <bhuvanchandra.dv@...adex.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"luwei.zhou@...escale.com" <luwei.zhou@...escale.com>,
	"LW@...o-electronics.de" <LW@...o-electronics.de>,
	"Frank.Li@...escale.com" <Frank.Li@...escale.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>
Subject: RE: [PATCH] net: fec: Fix dual ethernet issue in VFxx

From: Stefan Agner <stefan@...er.ch> Sent: Friday, January 09, 2015 4:22 PM
> To: Duan Fugang-B38611
> Cc: Bhuvanchandra DV; linux-kernel@...r.kernel.org; Zhou Luwei-B45643;
> LW@...o-electronics.de; Li Frank-B20596; davem@...emloft.net; u.kleine-
> koenig@...gutronix.de; shawn.guo@...aro.org
> Subject: RE: [PATCH] net: fec: Fix dual ethernet issue in VFxx
> 
> On 2015-01-09 04:00, fugang.duan@...escale.com wrote:
> > From: Stefan Agner <stefan@...er.ch> Sent: Friday, January 09, 2015
> > 2:59 AM
> >> To: Duan Fugang-B38611
> >> Cc: Bhuvanchandra DV; linux-kernel@...r.kernel.org; Zhou
> >> Luwei-B45643; LW@...o-electronics.de; Li Frank-B20596;
> >> davem@...emloft.net; u.kleine- koenig@...gutronix.de;
> >> shawn.guo@...aro.org
> >> Subject: RE: [PATCH] net: fec: Fix dual ethernet issue in VFxx
> >>
[snip]
> 
> Currently, MAC1 is broken in case 3 on Vybrid (as well as i.MX6XS and
> i.MX7, because the FEC_QUIRK_ENET_MAC is enabled for all of them).
> 
> > For all these cases, your above patches cannot handle these.
> 
> Yes, in it's current state, I agree. A new revision is required.
> 
> > So I still insist to add another property for this to avoid the
> > existing dts files change.
> 
> But I don't think adding another device tree property is helping here.
> There is already a device tree standard how to describe the MDIO buses,
> why not just make use of them?
> 
> I will create a v2 patchset, so we have a new base to discuss this
> further.
> 
Don't invent new property, and compatible with above four cases (avoid existing dts changing), it is difficult.
Looking forward to your next patchset.

Regards,
Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/