linux-kernel - Fwd: [RFC PATCH 0/2] USB: input: yealink.c: update key mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 9 Jan 2015 13:40:28 +0100
From:	Henk <henk.vergonet@...il.com>
To:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Fwd: [RFC PATCH 0/2] USB: input: yealink.c: update key mappings

Hi Danielle,

Thanks for the '#' fix!

> DRIVER_VERSION should be updated?
Yes seems logical, considering that the API has changed slightly by
using NUMERIC scan commands. I would suggest:

#define DRIVER_VERSION "yld-20141222"

So users something is new and can track changes to your patches more easily.

> are both patches suitable for stable?

I would have no objection to that :)

Regards,
Henk Vergonet

On Mon, Dec 22, 2014 at 3:41 PM, Daniele Forsi <dforsi@...il.com> wrote:
>
> Hello,
>
> I have an Yealink USB phone which is handled by the yealink.c driver but the
> '#' key returns an unexpected value and keys labeled "RING" and "MUTE" do not
> return any value to userspace.
>
> In the first patch of this series I replace the combination KEY_LEFTSHIFT and
> KEY_3 with KEY_NUMERIC_POUND and I also replace other keys for internal consistency
> and with the cm109.c driver, which according to the comment in the code is derived
> from this one, is this the right approach?
>
> In the second patch I add two additional keys which could be handled by userspace:
>  "RING" whose purpose according to the user manual is to cycle all available ringtones
>  "MUTE" whose purpose is to mute the USB microphone
> which KEY_* values should be used for them?
>
> I have two more questions:
> DRIVER_VERSION should be updated?
> are both patches suitable for stable?
>
> Daniele Forsi (2):
>   USB: input: yealink.c: use KEY_NUMERIC_* for numeric keys, star and
>     pound
>   USB: input: yealink.c: add mapping for "RING" and "MUTE" keys
>
>  drivers/input/misc/yealink.c | 43 +++++++++++++++++++------------------------
>  1 file changed, 19 insertions(+), 24 deletions(-)
>
> --
> 2.1.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/