[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54AFCEE5.3060402@citrix.com>
Date: Fri, 9 Jan 2015 12:51:49 +0000
From: David Vrabel <david.vrabel@...rix.com>
To: Juergen Gross <jgross@...e.com>, <linux-kernel@...r.kernel.org>,
<xen-devel@...ts.xensource.com>, <konrad.wilk@...cle.com>,
<david.vrabel@...rix.com>, <boris.ostrovsky@...cle.com>
Subject: Re: [Xen-devel] [PATCH 3/3] xen: use correct type for physical addresses
On 08/01/15 17:01, Juergen Gross wrote:
> When converting a pfn to a physical address be sure to use 64 bit
> wide types.
>
> Also avoid invalidating memory for zero sized non-aligned extra
> memory regions.
"Also" means this bit should be in another patch...
> Signed-off-by: Juergen Gross <jgross@...e.com>
> Tested-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> ---
> arch/x86/xen/setup.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> index feb6d86..8839d7b 100644
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -160,6 +160,8 @@ void __init xen_inv_extra_mem(void)
> int i;
>
> for (i = 0; i < XEN_EXTRA_MEM_MAX_REGIONS; i++) {
> + if (!xen_extra_mem[i].size)
> + continue;
> pfn_s = PFN_DOWN(xen_extra_mem[i].start);
> pfn_e = PFN_UP(xen_extra_mem[i].start + xen_extra_mem[i].size);
> for (pfn = pfn_s; pfn < pfn_e; pfn++)
i.e., this hunk should be in a separate path.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists