linux-kernel - Re: [PATCH v8 14/14] perf: add ITRACE_START record to indicate that tracing has started

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150109141318.GR10476@twins.programming.kicks-ass.net>
Date:	Fri, 9 Jan 2015 15:13:18 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Robert Richter <rric@...nel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>,
	Andi Kleen <ak@...ux.intel.com>, kan.liang@...el.com,
	adrian.hunter@...el.com, markus.t.metzger@...el.com,
	mathieu.poirier@...aro.org, acme@...radead.org
Subject: Re: [PATCH v8 14/14] perf: add ITRACE_START record to indicate that
 tracing has started

On Fri, Jan 09, 2015 at 03:12:48PM +0100, Peter Zijlstra wrote:
> On Fri, Nov 14, 2014 at 03:43:47PM +0200, Alexander Shishkin wrote:
> > +++ b/include/uapi/linux/perf_event.h
> > @@ -750,6 +750,17 @@ enum perf_event_type {
> >  	 */
> >  	PERF_RECORD_AUX				= 11,
> >  
> > +	/*
> > +	 * Indicates that instruction trace has started
> > +	 *
> > +	 * struct {
> > +	 *	struct perf_event_header	header;
> > +	 *	u32				pid;
> > +	 *	u32				tid;
> 
> The below function suggests we should have:
> 
> 		struct sample_id		sample_id;
> 
> > +	 * };
> > +	 */
> > +	PERF_RECORD_ITRACE_START		= 12,

This also raises the question; why not use PERF_RECORD_COMM?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/